Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix error #792

Merged
merged 1 commit into from
Oct 19, 2023
Merged

fix error #792

merged 1 commit into from
Oct 19, 2023

Conversation

publu
Copy link
Contributor

@publu publu commented Oct 18, 2023

the template doesn't run. it wasn't connecting bc of the wrong variable from rainbowkit, i spent a few more hours debugging, it still doesn't run.

would recommend unbundling this megarepo so yall can use CI to track and test more efficiently

@Aman035
Copy link
Member

Aman035 commented Oct 19, 2023

Hey @publu thanks for reporting this.
Mostly the template is for a simple usage examples thats why we don't track it in CI

@Aman035 Aman035 requested a review from madhur-push October 19, 2023 06:38
Copy link
Contributor

@madhur-push madhur-push left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@madhur-push madhur-push merged commit e67a6ee into push-protocol:main Oct 19, 2023
1 check failed
@gitpoap-bot
Copy link

gitpoap-bot bot commented Oct 19, 2023

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2023 Push Protocol Contributor:

GitPOAP: 2023 Push Protocol Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants